Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement @optStrategy UDA. #1637

Merged
merged 1 commit into from
Jul 24, 2016
Merged

Conversation

JohanEngelen
Copy link
Member

@JohanEngelen JohanEngelen commented Jul 23, 2016

I need this for debugging so implemented it. Any alternative ideas for the name "optStrat"?

Resolves #1549.

druntime change: ldc-developers/druntime@1a71859

@kinke
Copy link
Member

kinke commented Jul 23, 2016

Thanks, makes a lot of sense. I'd prefer optStrategy to make clear we're not talking about optimization stratosphere or something. ;)

@JohanEngelen
Copy link
Member Author

I changed the name to optStrategy.

@JohanEngelen JohanEngelen changed the title Implement @optStrat UDA. Implement @optStrategy UDA. Jul 24, 2016
@JohanEngelen
Copy link
Member Author

Fixed merge conflict (because of druntime changes).

ready to merge?

@@ -147,6 +148,30 @@ void applyAttrLLVMFastMathFlag(StructLiteralExp *sle, IrFunction *irFunc) {
}
}

void applyAttrOptStrat(StructLiteralExp *sle, IrFunction *irFunc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptStrategy here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kinke kinke merged commit e9f4ff2 into ldc-developers:master Jul 24, 2016
@JohanEngelen
Copy link
Member Author

thanks!
(now on to the real bug then......)

@JohanEngelen JohanEngelen deleted the optnone branch July 24, 2016 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants