Skip to content

Phobos: Boost some transcendental math functions for float/double#2624

Closed
kinke wants to merge 1 commit intoldc-developers:masterfrom
kinke:math_trans
Closed

Phobos: Boost some transcendental math functions for float/double#2624
kinke wants to merge 1 commit intoldc-developers:masterfrom
kinke:math_trans

Conversation

@kinke
Copy link
Member

@kinke kinke commented Mar 24, 2018

Based on upstream PR dlang/phobos#6272.

@kinke
Copy link
Member Author

kinke commented Mar 24, 2018

lit-test tests/compilable/ctfe_math.d fails because the newly introduced, statically unrolled poly() version isn't CTFE-able (I guess due to passing a static immutable static array by ref).

@kinke
Copy link
Member Author

kinke commented Mar 25, 2018

That additional poly() version doesn't affect the optimized LDC timings for the transcendental math functions, i.e., the existing slice-version is apparently inlined and unrolled as it should.
So in theory I could just add that additional version for DMD only; the proper way to fix the failure is probably to wait for dlang/dmd#8071 and then add the new float/double versions as CTFE builtins too.

@kinke
Copy link
Member Author

kinke commented Aug 17, 2018

A (slightly updated) version of this is incorporated in branch ldc-merge-2.082, as the upstream pull was merged just in time.

@kinke kinke closed this Aug 17, 2018
@kinke kinke deleted the math_trans branch August 17, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant