Fix compilation with LLVM11 #3322
Conversation
|
Can you also add the usual LLVM upgrade things? FindLLVM.cmake, FileCheck, and profdata. See https://github.com/ldc-developers/ldc/pull/3323/files |
|
[ |
thewilsonator
force-pushed
the
llvm11
branch
from
2be9bde to
e9561e1
Compare
|
Added llvm config names. If kinke wants to do the intrinsics later, then this is good to go. |
| @@ -30,6 +30,8 @@ IRScope::IRScope() : builder(gIR->context()) { begin = nullptr; } | |||
|
|
|||
| IRScope::IRScope(llvm::BasicBlock *b) : begin(b), builder(b) {} | |||
|
|
|||
| IRScope::IRScope(const IRScope &other) : begin(other.begin), builder(begin) {} | |||
There was a problem hiding this comment.
IRBuilder had its copy constructor deleted...
| @@ -231,7 +231,7 @@ class ArrayFI : public TypeInfoFI { | |||
| } | |||
|
|
|||
| Value *promote(CallSite CS, IRBuilder<> &B, const Analysis &A) override { | |||
| IRBuilder<> Builder = B; | |||
| IRBuilder<> &Builder(B); | |||
There was a problem hiding this comment.
Hence this change and the one below. I'm pretty sure this is not the right fix but I'm not sure what is.
There was a problem hiding this comment.
If we don't make a copy, then we should just use B instead of adding a reference to it. By not making a copy, my guess is that the insertion point of B is changed after leaving this function, whereas previously the insertion point stayed the same?
|
Superseded by #3546. |
No description provided.