-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor toir visit(StringExp) to avoid un-necessary computations. #3492
Conversation
You could just add an inline method returning a Lines 386 to 393 in 1494343
|
Thx for figuring out the test failures. - Seems like the code duplication is pointless, so this should be further refactored. It doesn't have to be you, and it doesn't have to be in this PR, but it's ugly as hell once one knows about it. |
Thx! I've pushed 2 more commits and am finally satisfied. ;) |
LGTM, the failure is due to a timeout. Not sure if you want to run it again? |
I've learned to accept unfortunate sporadic failures and CI hickups. [Plus I can't retrigger or cancel Travis jobs as I used to.] In case you're wondering about the formatting - we use clang-format for a consistent C++ style. |
This doesn't include peekData() as described in #3490 not sure about the process about updating the interface files, if it's fine I'll just add it into this PR.