Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3496 - missing IR declarations for some fwd-declared functions #3503

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

kinke
Copy link
Member

@kinke kinke commented Jul 10, 2020

Whenever we need an IR function, we'd better make sure it exists. Handle that in DtoCallee(), by invoking DtoDeclareFunction() by default, instead of the previous DtoResolveFunction() + DtoCallee() combo.
DtoResolveFunction() usually declares the function, but somehow doesn't for abstract and body-less functions.

…declared functions

Whenever we need an IR function, we'd better make sure it exists. Handle
that in DtoCallee(), by invoking DtoDeclareFunction() by default,
instead of the previous DtoResolveFunction() + DtoCallee() combo.
DtoResolveFunction() usually declares the function, but somehow doesn't
for abstract and body-less functions.
@kinke kinke merged commit 49affcf into ldc-developers:master Jul 13, 2020
@kinke kinke deleted the fix3496 branch July 13, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant