Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PGO instrumentation crash for final switch(enum) statements together with -release #3512

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

JohanEngelen
Copy link
Member

See GH issue #3375 (it fixes the instrumentation part of that bug on my machine, but apparently there are other bugs troubling PGO still).

This change includes checking of whether there is a default statement when using case <variable> (LLVM IR switch instruction cannot be used), although that is currently not allowed in the D language. Therefore there is no testcase that covers that.

…her with -release.

This change includes checking of whether there is a default statement when using `case <variable>` (LLVM IR switch instruction cannot be used), although that is currently not allowed in the D language. Therefore there is no testcase that covers that.

See GH issue #3375
@JohanEngelen
Copy link
Member Author

thanks for the review

@JohanEngelen JohanEngelen merged commit fd9d231 into master Jul 22, 2020
@JohanEngelen JohanEngelen deleted the fixPGOfinalswitch branch July 22, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants