Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump LDC-LLVM to v10.0.1 #3513

Merged
merged 2 commits into from
Jul 24, 2020
Merged

CI: Bump LDC-LLVM to v10.0.1 #3513

merged 2 commits into from
Jul 24, 2020

Conversation

kinke
Copy link
Member

@kinke kinke commented Jul 22, 2020

No description provided.

@@ -18,16 +18,15 @@ steps:
tar -xf ninja-mac.zip -C ninja
else
export DEBIAN_FRONTEND=noninteractive
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
CLANG_MAJOR=${CLANG_VERSION%%\.*}
sudo add-apt-repository "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-$CLANG_MAJOR main"
Copy link
Member Author

@kinke kinke Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched to their official 'nightlies' (e.g., currently actually 2 weeks old) apt repo because they've somehow moved to Ubuntu 18.04 for their x86_64 package with LLVM 10 (and that doesn't work on our 16.04, I've already tried it). They still use Ubuntu 16.04 for their PPC64le builds, so I guess this inconsistency stems from different people uploading their builds...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run into that issue several times in the past. I've asked about the issue and the answer was that builds are manually created and uploaded. They also said that https://releases.llvm.org is more or less only the official place to get binaries for Windows. Other platforms are expected to get them from the package manager.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's really not very professional from their side, leading to stuff like

ldc/.travis.yml

Lines 53 to 57 in 10cf5f0

elif [ "$LLVM_VERSION" = "9.0.0" ]; then
export LLVM_ARCH="x86_64-darwin-apple"
else
export LLVM_ARCH="x86_64-apple-darwin"
fi
.

@kinke
Copy link
Member Author

kinke commented Jul 22, 2020

Apple users: is -llibxml2.tbd supposed to ever work (apparently newly spit out as LLVM linker flag)? I've heard about .tbd files for the first time a few weeks ago by @jacob-carlborg.

@kinke kinke force-pushed the llvm_10.0.1 branch 2 times, most recently from d054525 to a7cccd2 Compare July 22, 2020 21:36
@JohanEngelen
Copy link
Member

I am still on macOS 10.13.6 (High Sierra), and llvm-config (trunk) --system-libs spits out -lz -lcurses -lm -lxml2

@jacob-carlborg
Copy link
Contributor

Apple users: is -llibxml2.tbd supposed to ever work (apparently newly spit out as LLVM linker flag)

I can't tell for sure (not currently at the computer) but I'm pretty sure a regular -l flag should be used, i.e. drop the prefix and file extension. The switch to tbd files are supposed to be transparent.

@kinke
Copy link
Member Author

kinke commented Jul 23, 2020

Okay thx, that's what I've done, but wasn't sure whether it should be something like -Wl,libxml2.tbd.

@jacob-carlborg
Copy link
Contributor

Apple users: is -llibxml2.tbd supposed to ever work

I've double checked now, here's the result:

  • -llibxml2.tbd does not work
  • -lxml2 does work
  • -Wl,libxml2.tbd does not work
  • The -Wl flag + full path to the .tbd file works

-lxml2 is the correct flag.

llvm-config --system-libs, using LLVM 10.0.1-rc1, outputs this for me: -lz -lcurses -lm -lxml2.

@kinke
Copy link
Member Author

kinke commented Jul 23, 2020

Thx again. FWIW, the Azure Mac image (for our LLVM CI) was bumped from 10.14 to 10.15, so that's probably what somehow caused this (I did some grepping in LLVM src but didn't find anything of relevance, so it looks like CMake's find_package gets it wrong for unknown reason).

@jacob-carlborg
Copy link
Contributor

FWIW, the Azure Mac image (for our LLVM CI) was bumped from 10.14 to 10.15.

I'm using 10.15. Perhaps CMake was updated in the process and is broken.

@kinke kinke merged commit 8bf323e into ldc-developers:master Jul 24, 2020
@kinke kinke deleted the llvm_10.0.1 branch July 24, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants