-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Bump LDC-LLVM to v10.0.1 #3513
Conversation
@@ -18,16 +18,15 @@ steps: | |||
tar -xf ninja-mac.zip -C ninja | |||
else | |||
export DEBIAN_FRONTEND=noninteractive | |||
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - | |||
CLANG_MAJOR=${CLANG_VERSION%%\.*} | |||
sudo add-apt-repository "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-$CLANG_MAJOR main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've switched to their official 'nightlies' (e.g., currently actually 2 weeks old) apt repo because they've somehow moved to Ubuntu 18.04 for their x86_64 package with LLVM 10 (and that doesn't work on our 16.04, I've already tried it). They still use Ubuntu 16.04 for their PPC64le builds, so I guess this inconsistency stems from different people uploading their builds...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run into that issue several times in the past. I've asked about the issue and the answer was that builds are manually created and uploaded. They also said that https://releases.llvm.org is more or less only the official place to get binaries for Windows. Other platforms are expected to get them from the package manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's really not very professional from their side, leading to stuff like
Lines 53 to 57 in 10cf5f0
elif [ "$LLVM_VERSION" = "9.0.0" ]; then | |
export LLVM_ARCH="x86_64-darwin-apple" | |
else | |
export LLVM_ARCH="x86_64-apple-darwin" | |
fi |
Apple users: is |
d054525
to
a7cccd2
Compare
I am still on macOS 10.13.6 (High Sierra), and llvm-config (trunk) --system-libs spits out |
I can't tell for sure (not currently at the computer) but I'm pretty sure a regular |
Okay thx, that's what I've done, but wasn't sure whether it should be something like |
I've double checked now, here's the result:
|
Thx again. FWIW, the Azure Mac image (for our LLVM CI) was bumped from 10.14 to 10.15, so that's probably what somehow caused this (I did some grepping in LLVM src but didn't find anything of relevance, so it looks like CMake's |
I'm using 10.15. Perhaps CMake was updated in the process and is broken. |
No description provided.