Handle IR collisions wrt. built-in TypeInfos and make them mutable #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling the rt.util.typeinfo unittests leads to base-typed forward declarations of built-in TypeInfos colliding with the init symbols for their TypeInfo_* classes in rt.util.typeinfo. We've already had a workaround for this in one place (typinf.cpp); extend it to the other side as well (iraggr.cpp). Also make sure to emit the TypeInfo metadata even if the IR symbol already exists as init symbol. And finally, keep init symbols of built-in TypeInfo classes mutable just like any other TypeInfo, so that e.g. synchronized() can be used on the implicit monitor.
Don't store and check a back reference to the TypeInfo global. The association is already unambiguously expressed by the metadata name ending with the mangled name of the TypeInfo global. Removing this check fixes a problem when replacing a TypeInfo global at some point via IRState::setGlobalVarInitializer() (e.g., for the rt.util.typeinfo unittests), because llvm::ValueAsMetadata doesn't fully support LLVM's replace-all-uses-with.
kinke
force-pushed
the
builtin_typeinfo
branch
from
f1ca6f5 to
30921a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the
rt.util.typeinfounittests (mostly disabled until now) leads to base-typed forward declarations of built-in TypeInfos colliding with the init symbols for theirTypeInfo_*classes inrt.util.typeinfo.We've already had a workaround for this in one place (
typinf.cpp); extend it to the other side as well (iraggr.cpp).Also make sure to emit the TypeInfo metadata even if the IR symbol already exists as init symbol.
Also keep init symbols of built-in TypeInfo classes mutable just like any other TypeInfo, so that e.g.
synchronized()can be used on the implicit monitor.And finally, simplify the TypeInfo metadata for the GC2Stack pass.