druntime: Define rt.aaA.AA as naked pointer, no struct wrapper #3613
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we come up with a testcase that would catch this? |
|
~Any usage of AAs for such targets should very quickly show that something's off. A lit-test could theoretically import |
|
ah yes, I was confused about the WASM case, but that errored because of a user-written runtime. |
To fix ABI incompatibilities between the previous struct and `void*` used by the hardcoded compiler prototypes, e.g., for WebAssembly, which uses the default UnknownTargetABI, which uses LLVM byval for all structs and static arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix ABI incompatibilities between the previous struct and
void*used by the hardcoded compiler prototypes, e.g., for WebAssembly, which uses the defaultUnknownTargetABI, which uses LLVMbyvalfor all structs and static arrays.