Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing location information for error reporting of TypeInfo in b… #3632

Merged

Conversation

DaveP1776
Copy link
Contributor

…etterC

This fixes an issue where any instantiation of TypeInfo in the final
output would lead to a cryptic error with no file or line information.
This change brings ldc in line with dmd's reporting of the same error,
which at least gives file and line information to discover the problem.

DaveP1776 and others added 4 commits December 12, 2020 22:41
…etterC

This fixes an issue where any instantiation of TypeInfo in the final
output would lead to a cryptic error with no file or line information.
This change brings ldc in line with dmd's reporting of the same error,
which at least gives file and line information to discover the problem.
@kinke
Copy link
Member

kinke commented Dec 13, 2020

Thanks! I took the liberty of slightly revising (incl. an unrelated long-overdue mutable-to-const conversion) and adding a test.

@thewilsonator thewilsonator merged commit 06b1e22 into ldc-developers:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants