Emit lambdas as linkonce_odr, including contained globals #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As they are emitted into each referencing object file anyway. Handling the globals resolves issue ldc-developers#3648. I think this also solves issue ldc-developers#2968 - in the presumably rare event that you absolutely don't want to emit a function into its owning CU and only into each referencing CU, an enum-lambda can be used as shown in the testcase. With `pragma(inline, true)`, it'll most likely be actually inlined and not make it to the object files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are emitted into each referencing object file anyway.
Handling the globals resolves issue #3648.
I think this also solves issue #2968 - in the presumably rare event that you absolutely don't want to emit a function into its owning CU and only into each referencing CU, an enum-lambda can be used as shown in the testcase.
With
pragma(inline, true), it'll most likely be actually inlined and not make it to the object files.