Ignore -enable-cross-module-inlining if inlining is generally disabled #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People use `dflags "-enable-cross-module-inlining" platform="ldc"` in their dub.sdl files; default and debug builds without -O thus incur a superfluous compile-time cost for no benefit.
kinke
force-pushed
the
no_cross_without_O
branch
from
2788b9a to
3f3ed2d
Compare
kinke
commented
Feb 12, 2021
| int call_easily_inlinable(int i) | ||
| { | ||
| // DISABLED: call {{.*}} @easily_inlinable( | ||
| // CHECK: call {{.*}} @easily_inlinable( | ||
| return easily_inlinable(i); |
There was a problem hiding this comment.
The call was previously there for -enable-cross-module-inlining -O0 too.
|
Makes total sense. The flag is meant to tweak inlining behavior, and when inlining generally is not enabled, it should not be enabled by this flag for some special cases. Does this impact |
Nope, these functions circumvent this check: Lines 104 to 110 in aac1898 |
JohanEngelen
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People use
dflags "-enable-cross-module-inlining" platform="ldc"in theirdub.sdlfiles; default and debug builds without-Othus incur a superfluous compile-time cost (extraavailable_externallyemissions) for no benefit.