Fix overzealous toBasetype'ing for debuginfo types #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is at least required when debugging in VS on Windows.
In the VS debugger, this means that the displayed type is the floating- point one instead of the enum, but the enum value is displayed correctly - it was previously re-interpreted as integer of matching size.
kinke
changed the title
JohanEngelen
reviewed
Apr 6, 2021
| @@ -134,7 +135,7 @@ int byValue(ubyte ub, ushort us, uint ui, ulong ul, | |||
| */ | |||
| size_t byValueShort(Large large) | |||
| { | |||
| // CDB: bp1 /1 `args_cdb.d:137` | |||
| // CDB: bp1 /1 `args_cdb.d:138` | |||
There was a problem hiding this comment.
fyi, FileCheck also gives you [[@LINE]] or [[@LINE+<offset>]] to check for linenumber output. https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-pseudo-numeric-variables
There was a problem hiding this comment.
I know, but this isn't run through FileCheck (CDB lines extracted via sed, see line 12).
There was a problem hiding this comment.
ah yes of course, sorry for silly remark!
There was a problem hiding this comment.
Don't be, thanks for taking a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3688.