-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overzealous toBasetype'ing for debuginfo types #3694
Conversation
This is at least required when debugging in VS on Windows.
In the VS debugger, this means that the displayed type is the floating- point one instead of the enum, but the enum value is displayed correctly - it was previously re-interpreted as integer of matching size.
@@ -134,7 +135,7 @@ int byValue(ubyte ub, ushort us, uint ui, ulong ul, | |||
*/ | |||
size_t byValueShort(Large large) | |||
{ | |||
// CDB: bp1 /1 `args_cdb.d:137` | |||
// CDB: bp1 /1 `args_cdb.d:138` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, FileCheck also gives you [[@LINE]]
or [[@LINE+<offset>]]
to check for linenumber output. https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-pseudo-numeric-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but this isn't run through FileCheck (CDB
lines extracted via sed
, see line 12).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes of course, sorry for silly remark!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be, thanks for taking a look!
Resolves #3688.