Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overzealous toBasetype'ing for debuginfo types #3694

Merged
merged 6 commits into from
Apr 10, 2021

Conversation

kinke
Copy link
Member

@kinke kinke commented Apr 4, 2021

Resolves #3688.

kinke added 3 commits April 5, 2021 22:07
This is at least required when debugging in VS on Windows.
In the VS debugger, this means that the displayed type is the floating-
point one instead of the enum, but the enum value is displayed
correctly - it was previously re-interpreted as integer of matching
size.
@kinke kinke changed the title WIP: Fix overzealous toBasetype'ing for debuginfo types Fix overzealous toBasetype'ing for debuginfo types Apr 5, 2021
@@ -134,7 +135,7 @@ int byValue(ubyte ub, ushort us, uint ui, ulong ul,
*/
size_t byValueShort(Large large)
{
// CDB: bp1 /1 `args_cdb.d:137`
// CDB: bp1 /1 `args_cdb.d:138`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, FileCheck also gives you [[@LINE]] or [[@LINE+<offset>]] to check for linenumber output. https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-pseudo-numeric-variables

Copy link
Member Author

@kinke kinke Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but this isn't run through FileCheck (CDB lines extracted via sed, see line 12).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes of course, sorry for silly remark!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be, thanks for taking a look!

@kinke kinke merged commit 1c75053 into ldc-developers:master Apr 10, 2021
@kinke kinke deleted the di branch April 10, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums are not showing up correctly as members of a struct when debugging.
2 participants