Revise Dto{MemCpy,MemSet[Zero],Load,Store} helpers, mainly wrt. proper alignment #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we've mostly been assuming the worst case so far, an alignment of 1 for both source and destination. Try to use the D type alignments explicitly wherever possible, and allow for different source/destination alignments. Also get rid of the optional `withPadding` arg for the version deriving the size automatically, and switch from unpadded-size-by-default to the padded size. Motivation: a memcpy of 10 bytes for an x87 real is most likely more involved than copying 12/16 bytes etc.
And switch to the padded size when deriving the size.
At least trying to. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #3698 because it started out as a follow-up (and would lead to later conflicts otherwise).