-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Bump LDC-LLVM to v12.0.0 #3701
Conversation
cb43af4
to
8c154a5
Compare
8dd690a
to
c8a62e5
Compare
Remaining failures:
|
Including bumping the Ubuntu base image from 16.04 to 18.04.
tests/PGO/indirect_calls.d
Outdated
@@ -2,6 +2,9 @@ | |||
|
|||
// REQUIRES: PGO_RT | |||
|
|||
// PROFUSE IR matching has regressed on Windows since LLVM 12 (due to our manual @weak emulation?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work if you remove @weak
and add inline asm noop or something else that prevents the optimizer from knowing what the function does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, asm {}
makes it work. 👍
As the PROFUSE IR matching has regressed on Windows with LLVM 12, apparently related to `@weak`.
As this trips up the optimized std.conv unittests on 32-bit x86 since LLVM 12.
Including bumping the Ubuntu base image from 16.04 to 18.04.