CI: Ship reggae with prebuilt packages #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
reggae
branch
3 times, most recently
from
68f6b52 to
ee02cb3
Compare
Incompatibilities with LDC and Windows in general have recently been fixed. @atilaneves is fine with reggae being included.
kinke
commented
May 26, 2021
| git clone --recursive https://github.com/atilaneves/reggae.git | ||
| cd reggae | ||
| git checkout "$(cat $BUILD_SOURCESDIRECTORY/packaging/reggae_version)" | ||
| DFLAGS="-O $DFLAGS" ../host-ldc/bin/dub build -v --build-mode=allAtOnce --combined \ |
There was a problem hiding this comment.
--build-mode=allAtOnce is a workaround for the dub issue fixed in dlang/dub#2135 - compiling & linking at once avoids the 'linker D flag' filtering.
--combined for a similar effect as LTO, compiling reggae and its dub library dependency to a single object file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incompatibilities with LDC and Windows in general have recently been fixed. @atilaneves is fine with reggae being included.