Add __traits(initSymbol, <aggregate type>) #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do submit this upstream |
|
I have 0 interest to tackle the DMD glue stuff but it's all prepared for simple upstreaming (that's why it's not in |
thewilsonator
added a commit
to thewilsonator/dmd
that referenced
this pull request
Jun 27, 2021
thewilsonator
added a commit
to thewilsonator/dmd
that referenced
this pull request
Jun 27, 2021
|
Noted, added upstream PR to reduce frontend diff |
|
Nice, much better than the pragma hack indeed. |
A clean way of directly accessing struct and class init symbols. It yields a `const(void[])` slice; the length reflecting the struct/class instance size, and the pointer either pointing to the init symbol or being null for zero-initialized structs. Paves the way for resolving ldc-developers#3773 in druntime as well as accessing class init symbols without `TypeInfo_Class.initializer()` indirection, and so with -betterC as well.
|
Reverted from |
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 13, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 13, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 13, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 13, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 13, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
MoonlightSentinel
added a commit
to MoonlightSentinel/dmd
that referenced
this pull request
Nov 16, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
dlang-bot
pushed a commit
to dlang/dmd
that referenced
this pull request
Nov 17, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
kinke
pushed a commit
to ldc-developers/dmd-testsuite
that referenced
this pull request
Dec 19, 2021
`__traits(initSymbol, S)` was introduced in ldc-developers/ldc#3774 and provides access to the initializer symbol of `S` in a way that does not rely on `TypeInfo` or other hacks. This commit contains some small adjustments to the initial patch which improve the user experience: - generated `VarExp` points to the `TraitsExp` instead of the symbol LoC - CTFE issues a specific error message - rejects interfaces because they don't have an initializer symbol and hence cause linker failures - more extensive tests Co-authored-by: Nicholas Wilson <iamthewilsonator@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clean way of directly accessing struct and class init symbols. It yields a
const(void[])slice; the length reflecting the struct/class instance size, and the pointer either pointing to the init symbol or being null for zero-initialized structs.Paves the way for resolving #3773 in druntime as well as accessing class init symbols without
TypeInfo_Class.initializer()indirection, and so with-betterCas well.