Fix #3778 - in-place construct <temporary>.ctor(args) #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanEngelen
reviewed
Jul 6, 2021
| // vector literals too | ||
| if (auto ve = rhs->isVectorExp()) { | ||
| // and vector literals | ||
| else if (auto ve = rhs->isVectorExp()) { |
There was a problem hiding this comment.
Because there is not a guaranteed return statement in the previous else-if (line 2852), this is slight change in behavior. Was that intentional?
There was a problem hiding this comment.
Yes, the elses are intentional - no point in continuing the checks for other types of expressions if we know it was another one and couldn't be in-place constructed.
I might go with a recursive approach for the ctor case; I thought that was infeasible because I thought lhs was an Expression too, but it's a DValue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.