Make sure special struct TypeInfo members are semantically analyzed before emitting the TypeInfo #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
commented
Jul 7, 2021
…efore emitting the TypeInfo As there are apparently cases where the struct hasn't had semantic3 yet, at least with -linkonce-templates. This prevents erroneous xopCmp etc. (failing to compile) from being referenced in the TypeInfo (=> linker errors) / being analyzed for -linkonce-templates codegen. `semanticTypeInfoMembers()` replaces them by `object._xopCmp()` etc. if compilation fails.
|
Sorry, can't be bothered to spend hours on setting up a dustmite run for a nicely reduced testcase... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are apparently cases where the struct hasn't had semantic3 yet, at least with
-linkonce-templates. This prevents erroneousxopCmpetc. (failing to compile) from being referenced in the TypeInfo (=> linker errors) / being analyzed for-linkonce-templatescodegen.semanticTypeInfoMembers()replaces them byobject._xopCmp()etc. if compilation fails.