Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-dllimport=defaultLibsOnly: Avoid -linkonce-templates requirement #3816

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

kinke
Copy link
Member

@kinke kinke commented Aug 16, 2021

Via a sorts-of '-linkonce-templates light', only defining all data symbols instantiated from druntime/Phobos templates in each referencing CU (as weak_odr).

Via a sorts-of '-linkonce-templates light', only defining all *data*
symbols instantiated from druntime/Phobos templates in each
referencing CU.
@kinke kinke marked this pull request as ready for review August 17, 2021 05:41
@kinke
Copy link
Member Author

kinke commented Aug 20, 2021

Tested on Symmetry's code base and apparently working fine, without a measurable compile-time impact (but fixing hundreds of undefined symbol linker errors previously requiring -linkonce-templates).

@kinke kinke merged commit 16b9eab into ldc-developers:master Sep 11, 2021
@kinke kinke deleted the dllimport branch September 11, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant