Store bool as i8 #386
Merged
Store bool as i8 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in line with an incoming upstream change making all polymorphic structs classes, and also matches common coding conventions.
Bug 9268 was fixed in 2.062.
I really hope we can refactor this to use a less leaky abstraction later – it should at least be possible to merge voidToI8 and i1ToI8.
|
Merging this to get some real-world testing as soon as possible. |
redstar
pushed a commit
that referenced
this pull request
Sep 27, 2014
Explicitly set AA value alignment in slot to size_t.sizeof bytes (fixes bug 8583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the hackish approach; I just added conversion in where necessary.
We should definitely at least get some semantic meaning in there (e.g.
DToStoreType), but I wanted to be sure we understand what needs to be changed first.