Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: Add new default lld switches to protect from stackoverflow overwriting global memory #3882

Merged
merged 4 commits into from
Dec 8, 2021
Merged

wasm: Add new default lld switches to protect from stackoverflow overwriting global memory #3882

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a69c26
Add new default ldc switches to protect from stackoverlow overwriting…
ryuukk Dec 7, 2021
7514bfc
Prefix linker flags with -L
ryuukk Dec 7, 2021
65402d7
Move new default switches out of the if LDC_WITH_LLD block
ryuukk Dec 8, 2021
a068c11
Remove empty lines
ryuukk Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,10 @@ elseif(${BUILD_SHARED_LIBS} STREQUAL "OFF")
set(ADDITIONAL_DEFAULT_LDC_SWITCHES "${ADDITIONAL_DEFAULT_LDC_SWITCHES}\n \"-link-defaultlib-shared=false\",")
endif()

# Default wasm stack is only 64kb, this is rather small, let's bump it to 1mb
set(WASM_DEFAULT_LDC_SWITCHES "${WASM_DEFAULT_LDC_SWITCHES}\n \"-L-z\", \"-Lstack-size=1048576\",")
# Protect from stack overflow overwriting global memory
set(WASM_DEFAULT_LDC_SWITCHES "${WASM_DEFAULT_LDC_SWITCHES}\n \"-L--stack-first\",")
if(LDC_WITH_LLD)
set(WASM_DEFAULT_LDC_SWITCHES "${WASM_DEFAULT_LDC_SWITCHES}\n \"-link-internally\",")
endif()
Expand Down