Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ldmd2 to support -vasm #3893

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Conversation

maxhaton
Copy link
Contributor

@maxhaton maxhaton commented Jan 7, 2022

No description provided.

@maxhaton
Copy link
Contributor Author

maxhaton commented Jan 7, 2022

@kinke

@thewilsonator
Copy link
Contributor

does DMD output the asm in addition to the binary? If so you might need additional --output-* arguments.

@kinke
Copy link
Member

kinke commented Jan 8, 2022

According to Walter's PR description, it prints the asm (per function, so not the full object file) and doesn't output a dedicated file like -output-s. I'm not convinced LDC needs a similar functionality, given what it already supports.

@maxhaton
Copy link
Contributor Author

maxhaton commented Jan 8, 2022 via email

@maxhaton
Copy link
Contributor Author

According to Walter's PR description, it prints the asm (per function, so not the full object file) and doesn't output a dedicated file like -output-s. I'm not convinced LDC needs a similar functionality, given what it already supports.

I've made it mimic dmd a bit more. This doesn't add any functionality, just mimics dmd as best as is currently possible. I assume one could inject a hook somewhere to print the instructions properly, but who cares since it's just a dmd compatibility layer.

@thewilsonator thewilsonator merged commit f154d67 into ldc-developers:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants