-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade frontend & libs to v2.100.0+ #3970
Conversation
So that it doesn't increase the overall struct size.
This fixes a bunch of importC dmd-testsuite tests.
Fixes dmd-testsuite's runnable/test22974.c.
…portC zero-init Fixes dmd-testsuite's runnable/test22994.c.
This fixes a bunch of importC dmd-testsuite tests.
Fixes dmd-testsuite's compilable/test22929.c.
Fixes dmd-testsuite's compilable/test22955.c.
…r importC AST) Fixing failing LDC assertions.
This fixes linker errors about a missing ModuleInfo section when ldc_rt.dso.o is pulled in for BUILD_SHARED_LIBS=ON builds (with implicit -link-defaultlib-shared).
The only remaining problem is a ldc/tests/sanitizers/asan_fakestack_GC.d Line 44 in 490bdcb
Edit: Unlikely, as the test works fine without |
Conflicts: runtime/CMakeLists.txt
E.g., for v2.100.0: libphobos2-ldc-shared.so -> libphobos2-ldc-shared.so.100 -> libphobos2-ldc-shared.so.100.0
@JohanEngelen: Can you be bothered to look at the test regression? It's of no priority to me, so I'd probably just disable it to move forward. |
[That same test just failed in another PR: https://cirrus-ci.com/task/6100113155162112] |
The ldc/tests/sanitizers/asan_fakestack_GC.d Line 29 in 490bdcb
It is testing GC functionality (which is not required to collect unused memory), and not fakestack functionality (done by test_non_null_does_not_trigger_collection ).
Edit: I added |
Hmm, I still find it somewhat worrying that it now apparently never collects the unreferenced garbage anymore; no idea how the fakestack works, but is there a chance the nullified pointer is still non-nullified in some GC-scanned memory block? And would that be considered legal? |
No description provided.