Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise DValue repainting #3991

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Revise DValue repainting #3991

merged 1 commit into from
Jul 12, 2022

Conversation

kinke
Copy link
Member

@kinke kinke commented May 30, 2022

Fixes #3990.

@thewilsonator
Copy link
Contributor

Ping, this good to go?

@kinke
Copy link
Member Author

kinke commented Jun 27, 2022

I'm a bit unsure about DFuncValue; that looks ill-designed from the start.

@kinke
Copy link
Member Author

kinke commented Jul 12, 2022

To be more precise: a bit unsure about whether non-delegate DFuncValues can ever end up in here (and what to do if they do). Anyway, that unexpected case would be reported as a 'proper' fatal error now.

@kinke kinke merged commit aa59b5a into ldc-developers:master Jul 12, 2022
@kinke kinke deleted the fix3990 branch July 12, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDC crashing on compiling code in 32-bit mode
2 participants
@kinke @thewilsonator