-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New exception chaining implementation #409
Conversation
Thanks a lot for doing this! I haven't looked at the generated code in detail yet, but I couldn't find any major issues at first glance. To get proper coverage on the CI systems, just push your druntime/dmd-testsuite commits to the ldc-developers repositories. Oh, and there might be another dmd-testsuite test or two you can enable now, just grep the source for |
Feel free to merge after the build is green. |
// the number of infos we had before the push | ||
std::stack<size_t> nInfos; | ||
// constructs the landing pad | ||
void constructLandingPad(IRLandingPadScope scope); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ref?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope is changed in the function.
The build is green, but I am pretty sure that the pull request breaks win64 exception handling since |
The Win64 build is currently broken. Just merge the pull request - I try to fix the Win64 build then. |
New exception chaining implementation
Ideal staging branch v2.062-b1 for druntime
No description provided.