Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exception chaining implementation #409

Merged
merged 3 commits into from
Jun 21, 2013

Conversation

AlexeyProkhin
Copy link
Member

No description provided.

@dnadlinger
Copy link
Member

Thanks a lot for doing this! I haven't looked at the generated code in detail yet, but I couldn't find any major issues at first glance.

To get proper coverage on the CI systems, just push your druntime/dmd-testsuite commits to the ldc-developers repositories.

Oh, and there might be another dmd-testsuite test or two you can enable now, just grep the source for version(LDC).

@dnadlinger
Copy link
Member

Feel free to merge after the build is green.

// the number of infos we had before the push
std::stack<size_t> nInfos;
// constructs the landing pad
void constructLandingPad(IRLandingPadScope scope);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const ref?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope is changed in the function.

@AlexeyProkhin
Copy link
Member Author

The build is green, but I am pretty sure that the pull request breaks win64 exception handling since _d_eh_handle_collision() is not implemented in eh2.d yet.

@redstar
Copy link
Member

redstar commented Jun 21, 2013

The Win64 build is currently broken. Just merge the pull request - I try to fix the Win64 build then.

dnadlinger added a commit that referenced this pull request Jun 21, 2013
New exception chaining implementation
@dnadlinger dnadlinger merged commit d0ef732 into ldc-developers:master Jun 21, 2013
@AlexeyProkhin AlexeyProkhin deleted the chaining branch July 10, 2013 16:19
redstar pushed a commit that referenced this pull request Sep 27, 2014
Ideal staging branch v2.062-b1 for druntime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants