Ensure LLVM LDFLAGS are placed after libraries in build commands. #452
Conversation
| @@ -429,7 +429,7 @@ set_target_properties(${LDMD_EXE} PROPERTIES | |||
| # use symbols from libdl, ..., so LLVM_LDFLAGS must come _after_ them in the | |||
| # command line. Maybe this could be improved using library groups, at least with | |||
| # GNU ld. | |||
| target_link_libraries(${LDMD_EXE} "${LLVM_LDFLAGS}" ${LLVM_LIBRARIES} "${LLVM_LDFLAGS}") | |||
| target_link_libraries(${LDMD_EXE} ${LLVM_LIBRARIES} "${LLVM_LDFLAGS}") | |||
There was a problem hiding this comment.
Sigh, I can't recall right now why I left the LDFLAGS in there twice, but there certainly was a reason. I guess the best way is to pull in this change and see what breaks. Please also update the comment to match the change, though.
There was a problem hiding this comment.
I did wonder if this particular change was wise, but I considered it could have just been an oversight to leave in the first instance.
There was a problem hiding this comment.
Not sure I understand your issue with the comment ... ?
There was a problem hiding this comment.
Sorry, I thought I had explicitly mentioned that the flags appear twice there. My mistake.
There was a problem hiding this comment.
That's actually why I thought the double occurrence was an oversight -- I assumed someone had copied them to the end, as per the comment, but just forgotten to delete the earlier one.
Ensure LLVM LDFLAGS are placed after libraries in build commands. Let's try this – add the removal of the second LLVM_LDFLAGS instance in the LDMD_EXE libraries if new LDMD linker errors pop up.
Remove unused Object.opEquals(Object, Object)
Some compilers require LDFLAGS to come after all other source/library files.
This should fix the issue described in the following discussion thread: http://forum.dlang.org/thread/kqvmreitlrmlegfthpgg@forum.dlang.org