Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to LDC-LLVM v17.0.6 #4540

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Switch to LDC-LLVM v17.0.6 #4540

merged 5 commits into from
Dec 4, 2023

Conversation

kinke
Copy link
Member

@kinke kinke commented Dec 3, 2023

No description provided.

@kinke kinke marked this pull request as ready for review December 4, 2023 14:56
@kinke
Copy link
Member Author

kinke commented Dec 4, 2023

I currently tend towards using this for the upcoming v1.36.0-beta1 release; the miscompile with LLVM 16 and opaque IR pointers (#4538) is really bad, so the original plan of using LLVM 16 and newly defaulting to opaque pointers is IMO not viable. Any opinions?

@JohanEngelen
Copy link
Member

OK.
I still hope to find some time to distill the miscompilation to an IR testcase. Maybe there is still some miscompilation lurking in llvm 17...

@kinke
Copy link
Member Author

kinke commented Dec 4, 2023

I'll give the beta some extensive tests on the Symmetry codebase then. - LLVM 16 seemed pretty buggy - first the func-specialization miscompiles, then the opaque pointers thing. Both of these seem to have been fixed in LLVM 17 now at least.

@kinke kinke merged commit f4b15f2 into ldc-developers:master Dec 4, 2023
@kinke kinke deleted the use_llvm_17 branch December 4, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants