Preliminary LLVM 20 support #4843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! How about becoming a member of ldc-developers, any interest? :) |
This is now required by LLVM API starting from LLVM 20
the-horo
suggested changes
Mar 5, 2025
There was a problem hiding this comment.
In gen_gccbuiltins.cpp you can get away with retroactively applying const instead of the LLVM_20_CONST conditional.
One more change that github doesn't let me submit:
- return TableGenMain(argv[0], emit);
+ // Since LLVM-20 `records` needs to be const&
+ return TableGenMain(argv[0], [](raw_ostream &os, auto &records){
+ return emit(os, records);
+ });
Comment on lines
+34
to
+40
| #if LDC_LLVM_VER >= 2000 | ||
| #define LLVM_20_CONST const | ||
| #else | ||
| #define LLVM_20_CONST | ||
| #endif | ||
|
|
||
| string dtype(LLVM_20_CONST Record* rec, bool readOnlyMem) |
There was a problem hiding this comment.
Suggested change
| #if LDC_LLVM_VER >= 2000 | |
| #define LLVM_20_CONST const | |
| #else | |
| #define LLVM_20_CONST | |
| #endif | |
| string dtype(LLVM_20_CONST Record* rec, bool readOnlyMem) | |
| string dtype(const Record* rec, bool readOnlyMem) |
| { | ||
| Init* typeInit = rec->getValueInit("VT"); | ||
| LLVM_20_CONST Init* typeInit = rec->getValueInit("VT"); |
There was a problem hiding this comment.
Suggested change
| LLVM_20_CONST Init* typeInit = rec->getValueInit("VT"); | |
| auto typeInit = rec->getValueInit("VT"); |
| @@ -72,7 +78,7 @@ string dtype(Record* rec, bool readOnlyMem) | |||
| return ""; | |||
| } | |||
|
|
|||
| StringRef attributes(ListInit* propertyList) | |||
| StringRef attributes(LLVM_20_CONST ListInit* propertyList) | |||
There was a problem hiding this comment.
Suggested change
| StringRef attributes(LLVM_20_CONST ListInit* propertyList) | |
| StringRef attributes(const ListInit* propertyList) |
| @@ -100,13 +106,13 @@ void processRecord(raw_ostream& os, Record& rec, string arch) | |||
| replace(name.begin(), name.end(), '_', '.'); | |||
| name = string("llvm.") + name; | |||
|
|
|||
| ListInit* propsList = rec.getValueAsListInit("IntrProperties"); | |||
| LLVM_20_CONST ListInit* propsList = rec.getValueAsListInit("IntrProperties"); | |||
There was a problem hiding this comment.
Suggested change
| LLVM_20_CONST ListInit* propsList = rec.getValueAsListInit("IntrProperties"); | |
| auto propsList = rec.getValueAsListInit("IntrProperties"); |
| const StringRef prop = | ||
| propsList->size() ? propsList->getElementAsRecord(0)->getName() : ""; | ||
|
|
||
| bool readOnlyMem = prop == "IntrReadArgMem" || prop == "IntrReadMem"; | ||
|
|
||
| ListInit* paramsList = rec.getValueAsListInit("ParamTypes"); | ||
| LLVM_20_CONST ListInit* paramsList = rec.getValueAsListInit("ParamTypes"); |
There was a problem hiding this comment.
Suggested change
| LLVM_20_CONST ListInit* paramsList = rec.getValueAsListInit("ParamTypes"); | |
| auto paramsList = rec.getValueAsListInit("ParamTypes"); |
| @@ -117,7 +123,7 @@ void processRecord(raw_ostream& os, Record& rec, string arch) | |||
| params.push_back(t); | |||
| } | |||
|
|
|||
| ListInit* retList = rec.getValueAsListInit("RetTypes"); | |||
| LLVM_20_CONST ListInit* retList = rec.getValueAsListInit("RetTypes"); | |||
There was a problem hiding this comment.
Suggested change
| LLVM_20_CONST ListInit* retList = rec.getValueAsListInit("RetTypes"); | |
| auto retList = rec.getValueAsListInit("RetTypes"); |
| @@ -145,7 +151,7 @@ void processRecord(raw_ostream& os, Record& rec, string arch) | |||
|
|
|||
| std::string arch; | |||
|
|
|||
| bool emit(raw_ostream& os, RecordKeeper& records) | |||
| bool emit(raw_ostream& os, LLVM_20_CONST RecordKeeper& records) | |||
There was a problem hiding this comment.
Suggested change
| bool emit(raw_ostream& os, LLVM_20_CONST RecordKeeper& records) | |
| bool emit(raw_ostream& os, const RecordKeeper& records) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds basic LLVM 20 support for LDC.
LLVM 20 changed a lot of APIs again, especially how passes are structured.