Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bundle arm64 libraries with Windows multilib package #4846

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

kinke
Copy link
Member

@kinke kinke commented Feb 26, 2025

No description provided.

@kinke
Copy link
Member Author

kinke commented Feb 26, 2025

FYI @rainers

@kinke kinke force-pushed the ci_winarm64 branch 2 times, most recently from f8b4776 to e30de7e Compare February 26, 2025 01:15
@rainers
Copy link
Contributor

rainers commented Feb 26, 2025

Nice. I think it's failing because cmake builds and runs test executables during the configuration phase that only run on an ARM64 system. Can this be disabled?

@rainers
Copy link
Contributor

rainers commented Feb 26, 2025

Not sure what the difference is, but for me, cross-compilation works when using

"c:\Program Files\Microsoft Visual Studio\2022\Preview\vc\Auxiliary\Build\vcvarsamd64_arm64.bat"

instead of

"c:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\Tools\VsDevCmd.bat" -arch=amd64

@kinke
Copy link
Member Author

kinke commented Feb 26, 2025

@kinke kinke force-pushed the ci_winarm64 branch 3 times, most recently from 5a0961c to 62e0632 Compare February 26, 2025 15:39
@kinke kinke marked this pull request as ready for review February 26, 2025 15:40
Copy link
Contributor

@rainers rainers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the zip in the artifacts, looks good. BTW: I recently also tried the prebuilt libcurl from https://curl.se/windows/, that worked for the phobos unittests, too. I don't remember why we have to compile libcurl ourselves...

@kinke
Copy link
Member Author

kinke commented Feb 27, 2025

BTW: I recently also tried the prebuilt libcurl from https://curl.se/windows/, that worked for the phobos unittests, too. I don't remember why we have to compile libcurl ourselves...

Did you test it on x64 or arm64? Great, I don't think they had usable official Windows builds when I last checked, years ago. I don't really remember why we built it ourselves either, but I think one reason was to have a static .lib and the .exp, to enable linking it statically (while still exporting those symbols, so that Phobos can load them from the executable). Looking at the lib dir in the official package, it has 14 .a libs for MinGW, unusable for MSVC.

And for 32-bit x86, we might have had to tweak the compile flags to make it work with the MinGW-based libs (disabling /GS etc.), but most likely just for the static lib again.

I've checked https://vcpkg.io/en/package/curl.html yesterday (wanting to use some prebuilt libcurl too), but looking at the 'Features' tab with all those dependencies made me quickly close the browser tab again... ;)

@kinke kinke merged commit c5f1944 into ldc-developers:master Feb 27, 2025
20 checks passed
@kinke kinke deleted the ci_winarm64 branch February 27, 2025 11:59
@rainers
Copy link
Contributor

rainers commented Mar 1, 2025

Sorry for the delay. I tested libcurl successfully on arm64. I guess you are right about the static library build, maybe they even had mingw runtime dependencies back then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants