driver/linker-gcc.cpp: Don't pass -rpath to linker on wasm targets #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-ld and lld::wasm don't understand the -rpath argument. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
kinke
reviewed
Feb 26, 2025
| @@ -613,7 +613,8 @@ void ArgsBuilder::build(llvm::StringRef outputPath, | |||
| } | |||
|
|
|||
| // -rpath if linking against shared default libs or ldc-jit | |||
| if (linkAgainstSharedDefaultLibs() || opts::enableDynamicCompile) { | |||
| if ((linkAgainstSharedDefaultLibs() || opts::enableDynamicCompile) | |||
| && !triple.isOSBinFormatWasm()) { // wasm-ld doesn't recognize -rpath | |||
There was a problem hiding this comment.
Really needed? wasm will most likely never support shared druntime/Phobos, nor dynamic-compile.
There was a problem hiding this comment.
Passing -link-defaultlib-shared when compiling with -defaultlib= or -betterC still passes -rpath making it fail. + it makes #4848 fail because I no longer strip the -link-defaultlib-shared that comes from -DBUILD_SHARED_LIBS=... in the wasm switches.
There was a problem hiding this comment.
Of course I could add it back but it seems more reasonable to ignore -link-defaultlib-shared, in my opinion at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-ld and lld::wasm don't understand the -rpath argument.