Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Bundle official libcurl builds #4855

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

kinke
Copy link
Member

@kinke kinke commented Feb 28, 2025

No description provided.

@kinke kinke force-pushed the libcurl_win_official branch from b3864dd to 940ce58 Compare February 28, 2025 14:10
@kinke
Copy link
Member Author

kinke commented Feb 28, 2025

FYI @rainers.

I've checked the deps of the x64 libcurl.dll, and it's looking very good:

>dumpbin /dependents libcurl-x64.dll
[…]
  Image has the following dependencies:

    bcrypt.dll
    CRYPT32.dll
    KERNEL32.dll
    Normaliz.dll
    api-ms-win-crt-convert-l1-1-0.dll
    api-ms-win-crt-environment-l1-1-0.dll
    api-ms-win-crt-filesystem-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-locale-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-private-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-time-l1-1-0.dll
    api-ms-win-crt-utility-l1-1-0.dll
    USER32.dll
    WLDAP32.dll
    WS2_32.dll

I.e., they even link the MSVCRT statically, so no need for the MSVC++ redistributable.

@kinke kinke marked this pull request as ready for review February 28, 2025 15:13
@kinke kinke force-pushed the libcurl_win_official branch from 940ce58 to f77a54a Compare February 28, 2025 15:52
@kinke
Copy link
Member Author

kinke commented Feb 28, 2025

Looking at #3638, I think the main reason for the former custom builds was the static lib (in MSVC-compatible .lib format), and making that static lib usable with the bundled MinGW-based libs. The DONT_USE_RECV_BEFORE_SEND_WORKAROUND workaround is almost certainly obsolete by now (or handled by the official builds).

Using the official builds should be much better wrt. Antivirus problems, and allows us much more easily to keep the bundled version reasonably up-to-date (edit: oh, trivial to use the very latest version, updated accordingly). Plus the feature set is most likely much higher (libssh2, zstd, brotli, …).

@kinke kinke force-pushed the libcurl_win_official branch from f77a54a to 1797217 Compare February 28, 2025 16:07
Copy link
Contributor

@rainers rainers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Having a signed libcurl.dll is a nice bonus indeed.

@kinke kinke merged commit d4dab47 into ldc-developers:master Mar 1, 2025
20 checks passed
@kinke kinke deleted the libcurl_win_official branch March 1, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants