Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmd/timetrace.d: Add namespace to C++ functions #4880

Open
wants to merge 1 commit into
base: merge-2.111
Choose a base branch
from

Conversation

the-horo
Copy link
Contributor

Add namespacing to the dmd functions to avoid symbol conflicts between them and the similar functions from driver/timetrace.d.

Add namespacing to the dmd functions to avoid symbol conflicts between
them and the similar functions from driver/timetrace.d.

Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
@the-horo
Copy link
Contributor Author

I suppose this has to be upstreamed as well but it's a quick fix to get the merge-2.111 branch to compile for me.

We could also apply the namespacing to the ldc timetrace.d but that would require a little bit more code change. Since the dmd timetrace.d came later I suppose it's on it to be compatible with the rest of the code

@kinke
Copy link
Member

kinke commented Mar 17, 2025

This is most likely just a bunch of copy&paste during upstreaming, so the conflicting functions most likely being totally identical, or almost identical. It just needs to be cleaned up. Putting the new upstream free functions in a dmd C++ namespace would make sense, but shouldn't be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants