dmd/timetrace.d: Add namespace to C++ functions #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add namespacing to the dmd functions to avoid symbol conflicts between them and the similar functions from driver/timetrace.d. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
|
I suppose this has to be upstreamed as well but it's a quick fix to get the We could also apply the namespacing to the ldc timetrace.d but that would require a little bit more code change. Since the dmd timetrace.d came later I suppose it's on it to be compatible with the rest of the code |
|
This is most likely just a bunch of copy&paste during upstreaming, so the conflicting functions most likely being totally identical, or almost identical. It just needs to be cleaned up. Putting the new upstream free functions in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add namespacing to the dmd functions to avoid symbol conflicts between them and the similar functions from driver/timetrace.d.