[WIP] Merged the 2.064 frontend #519
Conversation
|
Cool. This is really a strong argument to create the 0.12.0 release now. |
|
Seems like the new startup scheme still isn't reliable, as it seems to crash on all the Travis CI boxes, while it works fine locally. This was supposed to be more of a proof-of-concept for what I was thinking to do than a finished implementation anyway, though. Regarding the release, I'll push it out later today. Ideally, we'd then be able to release 2.064 at the same time (or shortly after) DMD is released. |
|
For sensible shared library support, we notably need to split up druntime and Phobos (i.e. not just copy druntime a second time into the Phobos library). I'd also take this opportunity to handle |
|
I probably won't be able to finish this in time, but if somebody else wants to: You can just revert the last (druntime module discovery-related) commit and most of the tests should again pass reliably. You maybe also have to add back in the explicit druntime initialization in dmain2.d (search for |
It is unused since my change to the way codegen is driven. If we want to optimize template codegen again, we should do it properly, contributing the changes back to DMD.
This corresponds to DMD commit a913ce4bc59a94a022a27e390fc841f4aededffb. Doesn't build Phobos yet.
In the 2.064 frontend, the catch variables have a zero initializer, so DtoDeclarationExp overwrote the actually caught exception with null.
This is the same implementation that is used for DMD and supports shared libraries (not yet tested).
|
The problem with the new module discovery seems to be that on shutdown, |
|
It turns out that in |
|
I merged the latest changes to druntime and phobos and created a branch from this pull request. I now try to update to latest beta and fix the errors. :-) |
|
@redstar: Must be a botched merge, sorry for the hassle. The druntime version linked in as a submodule was supposed to have that commit reverted. |
|
It seems that the unit test failure in the |
|
@redstar: Yes, they are. Off the top of my head, there are two ways of resolving this: Either change the druntime functions to accept/return void pointers (like the LDC-internal declarations do), or simply disable the tests/move them to a different file. I think I did the latter for one unittest added in an earlier releases, there is probably still an Apart from the tests, the mismatch isn't really a problem in practice as the code in rt.aaA, i.e. the module that implements AAs, obviously can't use constructs that generate AA calls anyway. Hm, thinking of it, I'm not sure what happens if you try to bitcode-link druntime into one module to use it for LTO – I never checked how the LLVM linker handles function type mismatch. |
This brings the source beyond beta4.
Some Travis-CI errors may be caused by out-of-memory.
Also includes latest druntime changes.
The DMD implementation is a bit odd. A parameter is passed to the function but the function itself is declared without a parameter. Then inline assembly is required to retrieve the parameter. Just do the same as gdc: declare the passed parameter.
Conflicts: runtime/phobos
Merged dmdfe changes in typeinf.c
The change not only makes the code cleaner but also fixes compilation of multiple files at once. Previously, fd->nestedVars may have been filled twice if fd was a template function instantiated in two modules simultaneously.
…d reference errors.
Conflicts: gen/runtime.cpp runtime/CMakeLists.txt
The name of the implicit called runtime function gives a hint about what goes wrong.
This is a replacement for the -noruntime switch. With the new DSO implementation every module generates runtime calls. The main motivation for the -noruntime switch is to avoid implicit GC calls. Therefore a dedicated -nogc switch is introduced.
This version uses the skipboundscheck member variable.
The new module discovery scheme requires the following section order: .minfo_beg .minfo .minfo_end This works for non-PIC code because the segments have the same attributes. However, if -relocation-model=pic is passed to ldc2 then the .minfo section becomes writeable and the sequence of sections is changed. The quick fix is to mark the data always as writeable. Then all sections are always writeable. I think a better solution would be to base this in the used relocation model. But this information is currently only available in the driver. This fixes the failure in test case runnable/eh2.d
Conflicts: gen/arrays.cpp
This fixes a segfault with associative array literals of arrays of associative array literals, which occured because of arrayLiteralToConst not handling null values properly. Ensuring that null pointers are handled correctly in all toConstElem callers is much more error-prone than just returning an LLVM undef, an error is emitted anyway. The root of the problem is actually in the kludgly implementation of AssocArrayLiteral::toElem, we should revisit this at some point.
Return undef instead of null on toConstElem failure.
|
I'm curious what the status is on this branch; it seems to work fine for all of my projects. Is there an estimate for when it might be merged? Thanks for all the hard work! |
|
@dymk All phobos/druntime unit tests passes except one. Therefore it should be quite usable (and thanks for trying out!). |
|
The std.uni discussion is in #594. |
Add in code paths for pthread sizes on non-x86 platforms.
This brings LDC to the level of dlang/dmd@a913ce4, i.e. somewhere around the second 2.064 beta.
dmd-testsuite has not been updated yet, the script for handling the repository (ldc-developers/ldc-scripts/dmd-testsuite) would have to be modified to also extract all the branches (no beta has been tagged yet).
Currently failing test cases: https://gist.github.com/klickverbot/7075137
This also includes an implementation of the new ModuleInfo discovery/druntime startup scheme on Linux which supports shared libraries. It didn't cause any regressions, at least not other than in the test cases failing anyway. Actually using it with shared objects has not been tested yet, though.