Fix a build issue where LLVM_LDFLAGS contains newlines. #691
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, a unit test is failling, but I don't see the connection with my change. I'm not sure in what environment it is run in, however I do not have the same problem when compiling locally. Could it be that the system ran out of memory? |
|
Yes, good old algorithm unittest. |
redstar
added a commit
that referenced
this pull request
Jul 29, 2014
Fix a build issue where LLVM_LDFLAGS contains newlines.
|
Thanks for the fix! |
redstar
pushed a commit
that referenced
this pull request
Sep 27, 2014
Fix InterlockedCompareExchange prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system. llvm_set returns a variable that contains newlines, which breaks the build. This fix makes sure that they are removed before setting LLVM_LDFLAGS for the last time.
Environment:
Linux kartofel 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
cmake version 2.8.12.2
llvm version 3.5