Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build issue where LLVM_LDFLAGS contains newlines. #691

Merged
merged 1 commit into from
Jul 29, 2014

Conversation

gballet
Copy link
Contributor

@gballet gballet commented Jul 28, 2014

On my system. llvm_set returns a variable that contains newlines, which breaks the build. This fix makes sure that they are removed before setting LLVM_LDFLAGS for the last time.

Environment:

Linux kartofel 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
cmake version 2.8.12.2
llvm version 3.5

@gballet
Copy link
Contributor Author

gballet commented Jul 28, 2014

Apparently, a unit test is failling, but I don't see the connection with my change. I'm not sure in what environment it is run in, however I do not have the same problem when compiling locally. Could it be that the system ran out of memory?

@Trass3r
Copy link
Contributor

Trass3r commented Jul 28, 2014

Yes, good old algorithm unittest.

redstar added a commit that referenced this pull request Jul 29, 2014
Fix a build issue where LLVM_LDFLAGS contains newlines.
@redstar redstar merged commit 514a96b into ldc-developers:master Jul 29, 2014
@gballet gballet deleted the fix-buildissues branch July 29, 2014 07:51
@redstar
Copy link
Member

redstar commented Jul 29, 2014

Thanks for the fix!

redstar pushed a commit that referenced this pull request Sep 27, 2014
Fix InterlockedCompareExchange prototype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants