stripModifiers() should recursively remove modifiers
#897
Conversation
Strip modifiers transitively when testing whether to repaint return type.
JohanEngelen
force-pushed
the
recursive_stripmodifiers
branch
from
d0e3f0e to
8396fc9
Compare
|
Rebased into one commit. Travis build is (virtually) green, and it fixes the Windows build partly: OK to merge? |
|
@JohanEngelen Merging is simple: you need both master and merge-2.067 branch locally. Checkout master, pull in changes, checkout merge-2.067, run git merge merge-2.067, resolve conflicts and push! |
|
Is this PR still required/recommended? |
|
@redstar Will check if still needed after recent commit. |
|
@redstar Actually, it is no longer needed because at the moment (after my Win64 ABI partial revert) there is no ABI that passes dynamic arrays via sret. But I still think we should merge this, so that in future we don't crash for sret dynamic arrays. (I am working on making it possible) Edit: if you agree, please hit the merge button :) |
|
Please merge if you think it is needed. |
`stripModifiers()` should recursively remove modifiers before equality check in return type repainting
This fixes an ICE on Win64/MSVC2013. See the discussion at the end of #856
Please verify that this is indeed the intended behavior of
stripModifiers()throughout LDC. If not, we could add an extrabool recursive = falseargument.If merged, please also merge into
merge-2.067. (I don't know how to cherrypick commits, still learning git)