PhenoOptiLIME

[DatSplit]

No description provided.

[ldingemans]

Hey @DatSplit thanks so much for the PR, overall it looks great, just one comment about some comments that are left in the code and could probably be removed.

Also, it looks like the LIME tests now take very long on Windows and therefore are failing after 360 min, any idea what is going on there?

[ldingemans]

This looks pretty good, but a lot of commented code still in there, maybe check if that can be removed?

[DatSplit]

Apologies, agreed! Removed superfluous comments.

[DatSplit]

@ldingemans Noticed that as well, unfortunately I do not have any idea what it might be.
It seems to be an "Open" issue: actions/runner-images#7320.
Might as well remove it for now, as this issue seems to be GitHub specific?
However, it used to work before I assume, so maybe the above issue is not the cause.

[DatSplit]

@ldingemans Never mind my previous comment (does not seem to be an issue anymore). Windows failed after 91m, because test_negative_control_permutation in test_permutation_test.py had a p-value smaller than 0.05:
Could be an intermittent issue caused by the shuffling and sampling in test_negative_control_permutation?

----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\PhenoScore\PhenoScore\phenoscore\tests\test_permutation_test.py", line 53, in test_negative_control_permutation
    assert permutation_tester.p_value > 0.05
AssertionError```