Lubcoercion #1
Merged
Lubcoercion #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easier to give my thoughts as a full pull request to your pull request than to try to spell out everything and have you interpret it, so here's a pull request with the output of my thoughts.
I split it into two commits. The first commit is a grab-bag of small changes, and I don't have much to say on them.
The second commit, I flipped the structure of the section so that it explains how the expected type interacts foremost. I removed the part saying what it is not, since it feels extraneous when starting with the actual effect.
--
By merging this PR to your branch, it'll automatically include the merged commits to your PR to rust-lang/reference.