Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past-the-end string parsing in extract_lexeme #17

Closed
futile opened this issue May 8, 2020 · 3 comments
Closed

Past-the-end string parsing in extract_lexeme #17

futile opened this issue May 8, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@futile
Copy link

futile commented May 8, 2020

The first loop in extract_lexeme (link) will continue past the end of the given string if the last character before the terminating 0 is a backslash (e.g., ./jtc -w '[\\' Bookmarks).

This is because the presence of the backslash will cause the iterator to be increased twice, thus skipping the terminating null-byte.

This bug was found using Symbolic Execution techniques developed in the course of the SYMBIOSYS research project at COMSYS, RWTH Aachen University. This research is supported by the European Research Council (ERC) under the EU's Horizon 2020 Research and Innovation Programme grant agreement n. 647295 (SYMBIOSYS).

@ldn-softdev
Copy link
Owner

Hi Futile,
thank you for catching this one, indeed, overlooked issue, luckily the fix is trivial.

btw, is SYMBIOSYS publicly available?

@ldn-softdev ldn-softdev added the bug Something isn't working label May 8, 2020
ldn-softdev pushed a commit that referenced this issue May 8, 2020
@ldn-softdev
Copy link
Owner

ldn-softdev commented May 8, 2020

I have posted the quick fixes for both issues, thanks again for reporting those!

@futile
Copy link
Author

futile commented May 8, 2020

Thanks for the quick confirmation! We are using a version of the KLEE symbolic execution engine (https://klee.github.io) with our implementation for C++ support, which is available from the existing PR: klee/klee#966.

Thanks for the quick fixes! :)

ldn-softdev pushed a commit that referenced this issue May 8, 2020
ldn-softdev pushed a commit that referenced this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants