Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Call a given function after calling the command (PostRun) #21

Merged
merged 2 commits into from
May 7, 2024

Conversation

GreyXor
Copy link
Contributor

@GreyXor GreyXor commented Feb 13, 2023

New postRun method that allows to automatically call a method after the execution of subcommands. (like preRun but after)

@GreyXor
Copy link
Contributor Author

GreyXor commented Mar 12, 2023

Hello @leaanthony 👋,
Would you like to review and merge this PR ?
Thanks

@GreyXor
Copy link
Contributor Author

GreyXor commented Sep 21, 2023

@leaanthony ?

Copy link
Owner

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! This slipped through the net. Just wondering what tests you've done with this

@GreyXor
Copy link
Contributor Author

GreyXor commented Sep 22, 2023

No problems :) , postRun() is effectively used in 2 of my programs since months. And the postRun function is working as expected to me.

@leaanthony
Copy link
Owner

Nice one. Could you please update the docs with the new flag and I'll get this in over the weekend 🙏

@GreyXor
Copy link
Contributor Author

GreyXor commented Sep 23, 2023

Nice one. Could you please update the docs with the new flag and I'll get this in over the weekend 🙏

Done, let me know if everything good for you

@GreyXor GreyXor closed this May 6, 2024
@GreyXor
Copy link
Contributor Author

GreyXor commented May 6, 2024

@leaanthony
Copy link
Owner

I was just reviewing it too :/

@GreyXor GreyXor reopened this May 7, 2024
@GreyXor
Copy link
Contributor Author

GreyXor commented May 7, 2024

So feel free to merge it, maybe that can be useful for someone else.

@leaanthony leaanthony merged commit 579f2a2 into leaanthony:master May 7, 2024
6 checks passed
@leaanthony
Copy link
Owner

Thanks!

@GreyXor
Copy link
Contributor Author

GreyXor commented May 9, 2024

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants