Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release tool #406

Closed
brunob opened this issue Oct 19, 2021 · 2 comments
Closed

Change release tool #406

brunob opened this issue Oct 19, 2021 · 2 comments

Comments

@brunob
Copy link
Member

brunob commented Oct 19, 2021

mversion seems a bit unmaintained : latest commit from 2020 & many dependabot PR waiting since a while https://github.com/mikaelbr/mversion/pulls

Even if mversion still work for now, the dependabot message "We found potential security vulnerabilities in your dependencies." point to an alert linked to mversion.

I've started to search for an alternative tool, and found these one :

Bonus, all these tools could also fix #320 !

Any thoughts @jieter ?

@jieter
Copy link
Contributor

jieter commented Oct 19, 2021

Yes, we should probably bring this process up to date. Ideally, I'd like to be able to release from within GitHub. I never looked into this before, but a quick google search surfaced this action:

https://github.com/marketplace/actions/npm-bump

From it's description, it turns out the npm tool already supports incrementing the version: https://docs.npmjs.com/cli/v7/commands/npm-version#description. This might be enough to replace mversion.

@brunob
Copy link
Member Author

brunob commented Oct 19, 2021

Yes, we should probably bring this process up to date. Ideally, I'd like to be able to release from within GitHub. I never looked into this before, but a quick google search surfaced this action:

https://github.com/marketplace/actions/npm-bump

Nice, that's the one i've found the most suitable for our needs :)

From it's description, it turns out the npm tool already supports incrementing the version: https://docs.npmjs.com/cli/v7/commands/npm-version#description. This might be enough to replace mversion.

I've seen that too.

Anyway, nice things to come :)

brunob added a commit that referenced this issue Sep 2, 2022
@brunob brunob closed this as completed in 3b7bd4f Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants