-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New providers added #267
New providers added #267
Conversation
@chatelao thanks for your PR. Can you pllease have a look at why the tests fail, and fix those issues? |
Fix applied (formating error) |
leaflet-providers.js
Outdated
OpenSeaMap: { | ||
url: 'https://tiles.openseamap.org/seamark/{z}/{x}/{y}.png', | ||
options: { | ||
attribution: 'Map data: © <a href="http://www.openseamap.org">OpenSeaMap</a> contributors' | ||
} | ||
}, | ||
OpenPtMap: { | ||
maxZoom: 17, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one has to go into options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look. Something seamed wierd with the zoom levela.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top level object should only have keys url
, options
and variants
, so the maxZoom
should not be in L.TileLayer.Provider.providers.OpenPtMap
but in L.TileLayer.Provider.providers.OpenPtMap.options
.
You are so nice and helpful. I will commit after fixing. Maybe you tests support checking a json schema? I could try to create one. |
Next try :-) |
I just was in the wrong branch :-(
Thank you for your pation with a newbie. |
I added a bit more strictness to the tests, which can be seen here. This looks good to me, I'm merging. For next time, it's helpful to include all layer's you are adding with the PR to the description of the PR and if possible include links to their usage terms. |
@chatelao if I may suggest some improvements:
|
Okay, I will try this. Didn't see this part of the code (yet). |
OpenFireMap, OpenInfraMap