-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove homegrown retina detection #282
Conversation
@brunob, can you have a look? |
@jieter ok i'll do that today |
GTM for me :) |
@jieter can i remove the topic branch safely ? |
Yes! |
maybe also a good time to do new release? |
Branch deleted and gogogo for the release :) |
@jieter i'm ready to push a new release, what do you think about a 1.2.0 version since the retina change is not really a "small one" ? |
👍 |
@jieter do we have a script to generate the changelog or do you make it manually ? |
Manually, unfortunately
…On June 5, 2018 8:16:05 PM GMT+02:00, b_b ***@***.***> wrote:
@jieter do we have a script to generate the changelog or do you make it
manually ?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#282 (comment)
|
'k, i'm on it |
@jieter here is the changelog for review 176a896 Feel free to push the release, i'm not sure if https://github.com/leaflet-extras/leaflet-providers/wiki is up to date about it :) |
yay: https://www.npmjs.com/package/leaflet-providers/v/1.2.0 the wiki was still the correct procedure, except for the last step, which isn't necessary anymore, so I removed it. Thanks for doing the changelog work! |
@jieter maybe we could use a tool like https://github.com/conventional-changelog/standard-version for changelog+release ? |
I never looked into it, but more automation in the deployment process would be nice |
and
{r}
to Stamen and CartoDB urls (replaces Ref #251 : Handle retina for Stamen & CartoDB tiles #257 and Stamen retina works now #251)