Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove homegrown retina detection #282

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Remove homegrown retina detection #282

merged 2 commits into from
Jun 5, 2018

Conversation

jieter
Copy link
Contributor

@jieter jieter commented Jun 5, 2018

and

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018

@brunob, can you have a look?

@brunob
Copy link
Member

brunob commented Jun 5, 2018

@jieter ok i'll do that today

@brunob
Copy link
Member

brunob commented Jun 5, 2018

GTM for me :)

@jieter jieter merged commit 826ef52 into master Jun 5, 2018
@brunob
Copy link
Member

brunob commented Jun 5, 2018

@jieter can i remove the topic branch safely ?

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018

Yes!

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018

maybe also a good time to do new release?

@brunob brunob deleted the remove-fakeretina branch June 5, 2018 15:17
@brunob
Copy link
Member

brunob commented Jun 5, 2018

Branch deleted and gogogo for the release :)

@brunob
Copy link
Member

brunob commented Jun 5, 2018

@jieter i'm ready to push a new release, what do you think about a 1.2.0 version since the retina change is not really a "small one" ?

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018

👍

@brunob
Copy link
Member

brunob commented Jun 5, 2018

@jieter do we have a script to generate the changelog or do you make it manually ?

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018 via email

@brunob
Copy link
Member

brunob commented Jun 5, 2018

'k, i'm on it

@brunob
Copy link
Member

brunob commented Jun 5, 2018

@jieter here is the changelog for review 176a896

Feel free to push the release, i'm not sure if https://github.com/leaflet-extras/leaflet-providers/wiki is up to date about it :)

@jieter
Copy link
Contributor Author

jieter commented Jun 5, 2018

yay: https://www.npmjs.com/package/leaflet-providers/v/1.2.0

the wiki was still the correct procedure, except for the last step, which isn't necessary anymore, so I removed it.

Thanks for doing the changelog work!

@brunob
Copy link
Member

brunob commented Mar 29, 2019

@jieter maybe we could use a tool like https://github.com/conventional-changelog/standard-version for changelog+release ?

@jieter
Copy link
Contributor Author

jieter commented Mar 29, 2019

I never looked into it, but more automation in the deployment process would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants