Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X509 signature algorithms such as RSA-SHA1 and ECDSA-with-SHA384 #130

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

gsimko
Copy link

@gsimko gsimko commented Oct 8, 2022

When using ECDSA certificate, the signature name is the full name (e.g., ecdsa-with-SHA384), but indeed should be the digest part only (e.g., SHA384). Similarly, RSA-SHA1 is broken now because it doesn't start with SHA1 hence it doesn't get replace with SHA256.

This PR fixes both of these problems.
It's an alternative proposal to #127 that works for all socket types but I didn't touch cqueues because I was not sure why it was hardcoded as SHA256.

@gsimko
Copy link
Author

gsimko commented Oct 8, 2022

It doesn't look like the unit tests are executed by github.
FWIW I have observed on my laptop that "make test" works fine but I couldn't get "make test_resty" to work (resty couldn't find the lua libraries installed by luarocks and lua 5.14 was not working with moonscript, etc, I gave up after an hour)

@leafo leafo merged commit e65af32 into leafo:master Oct 17, 2022
@leafo
Copy link
Owner

leafo commented Oct 17, 2022

Thanks, I'm fine with this for now until we get a more robust solution

@wombat
Copy link

wombat commented Nov 22, 2022

@leafo Do you have any timeline when a new release will be made, so kong can update its dependencies and crunchy postgres operator will be usable with it again?

@leafo
Copy link
Owner

leafo commented Nov 22, 2022

@wombat Sorry about the delay. Don't hesitate to bug me about pushing out a new version. Sometimes I sit on some changes for a bit in case other things come up. I've just released 1.16 to opm and luarocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants