Add minimal PHP version in composer.json #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
As the documentation explain that are needed.
for next Leaf version
mychidarko
requested changes
Aug 10, 2023
|
Already made 0b00257 |
mychidarko
approved these changes
Aug 10, 2023
|
Oh awesome. Merging now. |
|
Thanks for the contributions @joanhey. These are a really big help ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Require minimum PHP version.
Now install with any version, but later it will not work.
And inform to any developer only reading the
composer.json.Added also php extensions json and zip, as the documentation explain that are needed.
We can remove the need for extensions, but need to be added to the modules that need it.
But in reallity the App load automatically modules than need it.