Open
Conversation
jhallman5
reviewed
Feb 27, 2017
| h5, | ||
| h6 { | ||
| padding: 0; | ||
| margin: 0; |
There was a problem hiding this comment.
Is declaring padding and margin 0 necessary? Also if you declare this on the body, the objects ( divs, ul, etc) inside the body tag should also have these parameters.
jhallman5
reviewed
Feb 27, 2017
| <title>Resume</title> | ||
|
|
||
| <!-- Load the page styles. --> | ||
| <link href="css/style.css" rel="stylesheet"> |
There was a problem hiding this comment.
because you are referencing css/style.css you are using the css file in your css folder. As such your css in your udacity root folder is not being used for anything. I recommend deleting duplicate files whenever you can to both make it easier for you to manage and easier for the person reading it to pick up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is my code for this goal, see day one code from udacity in folder , did not finish entire goal