Play 2.9 & Scala 3 #321
Play 2.9 & Scala 3 #321
Conversation
RELEASE-NOTES.md
Outdated
There was a problem hiding this comment.
Included the changes to RELEASE-NOTES.md, version.sbt, and README.md to release 2.9, but feel free to drop these changes if you want to make them yourself!
AshCorr
force-pushed
the
ash/play-2.9
branch
4 times, most recently
from
d97acb7
to
2827377
Compare
AshCorr
force-pushed
the
ash/play-2.9
branch
3 times, most recently
from
e351f57
to
d45833a
Compare
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version = 1.3.12 | |||
| sbt.version = 1.5.0 | |||
There was a problem hiding this comment.
Scala 3 requires atleast SBT 1.5
There was a problem hiding this comment.
Play 2.9 requires at least sbt 1.9.6, not sure how this affect libraries such as this one though but upgrading to sbt 1.9.7 should be straightforward, isn't it?
There was a problem hiding this comment.
Ah good catch! Seems to compile fine and tests run, so lets bump it.
| @@ -45,16 +45,16 @@ class AuthenticationTest extends AnyFunSuite with Matchers with ScalaCheckProper | |||
| } | |||
|
|
|||
| a[UnsupportedOperationException] shouldBe thrownBy( | |||
| await(ws.url("/").withAuth("user", "s3cr3t", WSAuthScheme.NTLM).get) | |||
| await(ws.url("/").withAuth("user", "s3cr3t", WSAuthScheme.NTLM).get()) | |||
There was a problem hiding this comment.
Functions must be called using parenthesis in Scala now
| @@ -20,6 +20,9 @@ import scala.concurrent.Future | |||
| import scala.concurrent.duration._ | |||
| import org.scalatest.funsuite.AnyFunSuite | |||
| import org.scalatest.matchers.should.Matchers | |||
| import play.api.libs.ws.writeableOf_String | |||
There was a problem hiding this comment.
These are implicit BodyParser implementations for reading and writting Strings to request bodies. They now need to be imported explicitly in Scala 3 (I think? Scala 3 compilation wouldn't work unless I did).
There was a problem hiding this comment.
I had the same "issue" in my projects, not sure if that's really intended though.
….13 anymore so its not needed.
| @@ -22,21 +22,21 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| scala: [2.12.10, 2.13.1] | |||
| java: [temurin@8] | |||
| scala: [2.13.1, 3.3.1] | |||
There was a problem hiding this comment.
Why 2.13.1? The latest 2.13.x release is 2.13.12
Is this a typo, like everywhere in this PR?
There was a problem hiding this comment.
2.13.1 was the previously set version of Scala that this project was using, I avoided bumping anything more than I needed to get this project to work with Play 2.9 and Scala 3
What this changes
Play 2.9 was just released, this PR bumps
play-mockwsto the newest version. Play 3.x has also just been released but will involve some breaking changes, figure some people might have some benefit to having a Play 2.9 version of this library before then.How this was tested
Tests ran against Scala 2.13 and Scala 3 with:
sbt ++3.3.1! testsbt ++2.13.1! test