-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display automatic translations to informal math #168
Open
robertylewis
wants to merge
22
commits into
master
Choose a base branch
from
display-informal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7cec640
bump mathlib version
robertylewis 7ff6709
display informal translations
robertylewis 5328ddd
outdated css
robertylewis d46cddf
Update templates/decl.j2
robertylewis 3252777
change feedback links to form
EdAyers 411bfb0
fix: edit style
EdAyers 03443f8
Add translation form handler.
EdAyers 6624d54
Support feedback edit
EdAyers 6c05dba
hack to escape < in mathjax
robertylewis 42c2a9d
Send feedback as soon as user clicks No
EdAyers f9108f2
Fix double-counting ratings
EdAyers 4b847fa
Add toggle for opening or closing all informal statement panels
EdAyers 7470cdc
fix localstorage
EdAyers 935ca19
Apply suggestions from code review
EdAyers bbc1dfb
Refactor localstorage code for informalopen
EdAyers 93a69c5
Informal statement details are closed by default
EdAyers b31b053
semicolons everywhere
EdAyers 376fba4
more semicolons
EdAyers 46cc148
Merge branch 'master' into display-informal
robertylewis 846af1b
fix merge
robertylewis f8c1b50
lazy loading of math
robertylewis bab70a7
change configuration options header
robertylewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried the mathjax rendering is going to have quite a large impact on page load times. Could we maybe:
.informal_statement
until thedetails
is expandedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
details
should be collapsed by default, not for performance but because the translations are misleadingly sketchy:But a toggle also sounds like a good idea.
Do you know how to defer the rendering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a (possibly outdated) question about deferring here: https://stackoverflow.com/a/27952213/102441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page in the documentation also seems relevant.
Enabling Lazy Typesetting would also be a reasonable option.