-
Notifications
You must be signed in to change notification settings - Fork 298
feat(linear_algebra/clifford): make clifford_algebra irreducible in a Lean4 compatible way #18179
Conversation
We're currently hundreds of dependencies away from being able to port this file. I'd be curious to see whether we run into trouble with the reducible definition in Lean 4, before committing to all the boilerplate this entails; so would be tempted to leave this PR sitting around for a while until we get closer. |
We can definitely keep this around and only use it if necessary. Note however that in Lean 3, unmarking |
Thanks 🎉 bors merge |
@jcommelin, I'd prefer to leave this PR open until this file gets closer to being portable bors r- bors d+ |
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
Canceled. |
We're now on the cusp of being able to port this; I've left a note on the port comment page remarking that if we run intro trouble while porting, these changes might be useful. |
clifford_algebra
is a complicated object (building ontensor_algebra
which builds onfree_algebra
), which means Lean has difficulties working with it unless it is irreducible. In the current version, it is marked asirreducible
after the fact, which is not Lean4-compatible. Instead, we switch to a construction as a one-field structure, which is genuinally irreducible (modelled on what is done for real numbers).Part of #18164