This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Merged by Bors] - chore(order/liminf_limsup): Generalise and move lemmas #18628
[Merged by Bors] - chore(order/liminf_limsup): Generalise and move lemmas #18628
Changes from all commits
1342968
cd52388
0fef0de
46da942
9143398
8f37b0d
72502b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1 in src/data/set/finite.lean
GitHub Actions / Check for modifications to ported files
Check warning on line 1 in src/order/bounds/basic.lean
GitHub Actions / Check for modifications to ported files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PRs that need forward-porting, it would really be best not to make stylistic changes. Can't you just replace
semilattice_inf γ
withis_directed γ (≥)
(and fix docstrings) and not touch anything else?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially for things like reordering implicit arguments, as you've done here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What stylistic changes have I made? I made the explicit argument
a
implicit. This is not stylistic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It borders on stylistic, given the PR description makes no mention of it. I should have said "aesthetic" though I guess.
You also changed
γ
forα
, moved things after the colon, and reordered some arguments. These are all things that just make the forward-port review harder. Note that reordering arguments is particularly risky because it's hard to spot skimming a diff, and the#align
machinery doesn't do well if we screw up the forward-port.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now mentioned in the PR description. The only reason
\gamma
was used was because\alpha
is already declared to be apreorder
in the section.Check warning on line 1 in src/order/directed.lean
GitHub Actions / Check for modifications to ported files
Check warning on line 1 in src/order/liminf_limsup.lean
GitHub Actions / Check for modifications to ported files
Check warning on line 1 in src/topology/algebra/order/liminf_limsup.lean
GitHub Actions / Check for modifications to ported files